feat: avoid multiple types of select calls #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there are two scenarios when a select action type is found: - When an include has a select within it - When a select has a relation in it This means that there is a situation where it is not possible to reason about what to do with a select because the two scenarios look the same based on the available information; both have the include action as the parent. BREAKING CHANGE: remove the calls for include selects Middleware that relied on calls with the "select" action for select objects within an include will no longer be able to use that call. Instead use the parent "include" action to modify the selected fields, or use the "select" action for the relation within that select object.
olivierwilkinson
force-pushed
the
improve-rationality-of-calls-by-removing-include-select-calls
branch
from
50f62ad to
ad433d1
Compare
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are two scenarios when a select action type is found:
This means that there is a situation where it is not possible to reason about what to do with a select because the two scenarios look the same based on the available information; both have the include action as the parent.
BREAKING CHANGE: remove the calls for include selects
Middleware that relied on calls with the "select" action for select objects within an include will no longer be able to use that call. Instead use the parent "include" action to modify the selected fields, or use the "select" action for the relation within that select object.